ENH: add nanmax#847
Merged
Merged
Conversation
Member
|
as mentioned earlier, would be nice to see a branch with this and |
Contributor
Author
|
How should we test? Will you merge this and then I need to adjust the version of |
Member
|
you can checkout this branch of array-api-extra inside sklearn |
Contributor
Author
|
The CI in |
lucascolley
self-requested a review
July 13, 2026 21:31
Contributor
Author
|
@lucascolley Can we merge this one? |
lucascolley
requested changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #789
nanmax